Reduce messages from libjpeg-turbo

Reduce messages from libjpeg-turbo

output_message():
By overriding output_message, we can use SkCodecPrintf,
which we can turn on or off.

The default turbo implementation of emit_message calls
output_message when it wants to print a message, so,
even though we don't override emit_message, it also uses
SkCodecPrintf.

emit_message():
Use libjpeg-turbo’s default implementation of emit_message.

It does not print "trace messages" which essentially are info
messages and it only prints the first warning (unless it a very
serious warning).

Currently, we just print everything, which is why the output
has been so verbose.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/6dfe9ac3aad3ab8ec3a0f1684c94fef0c6ad9c3e

[msarett, 2015-11-10 15:22:57]

Description was changed from

==========
Reduce messages from libjpeg-turbo

BUG=skia:
==========

to

==========
Reduce messages from libjpeg-turbo

Take advantage of the default routines within libjpeg-turbo,
rather than printing every trace/warning message.

BUG=skia:
==========

[msarett, 2015-11-10 15:26:35]

msarett@google.com changed reviewers:
+ scroggo@google.com

[msarett, 2015-11-10 15:26:36]

https://codereview.chromium.org/1427523007/diff/1/src/codec/SkJpegDecoderMgr.cpp
File src/codec/SkJpegDecoderMgr.cpp (left):

https://codereview.chromium.org/1427523007/diff/1/src/codec/SkJpegDecoderMgr....
src/codec/SkJpegDecoderMgr.cpp:23: static void emit_message(j_common_ptr info,
int) {
The default implementation of emit_message is much better than this.

It does not print "trace messages" which essentially are info messages and it
only prints the first warning (unless it a very serious warning).

Currently, we just print everything, which is why the output has been so
verbose.

https://codereview.chromium.org/1427523007/diff/1/src/codec/SkJpegDecoderMgr.cpp
File src/codec/SkJpegDecoderMgr.cpp (right):

https://codereview.chromium.org/1427523007/diff/1/src/codec/SkJpegDecoderMgr....
src/codec/SkJpegDecoderMgr.cpp:23: static void output_message(j_common_ptr info)
{
By overriding output_message, we can use SkCodecPrintf, which we can turn on or
off.

The default turbo implementation of emit_message calls output_message when it
wants to print a message, so, even though we don't override emit_message, it
also uses SkCodecPrintf.

[scroggo, 2015-11-10 18:57:22]

nit: the commits you posted in codereview could be useful in the commit message.

lgtm

[msarett, 2015-11-10 19:10:25]

Description was changed from

==========
Reduce messages from libjpeg-turbo

Take advantage of the default routines within libjpeg-turbo,
rather than printing every trace/warning message.

BUG=skia:
==========

to

==========
Reduce messages from libjpeg-turbo

output_message():
By overriding output_message, we can use SkCodecPrintf,
which we can turn on or off.

The default turbo implementation of emit_message calls
output_message when it wants to print a message, so,
even though we don't override emit_message, it also uses
SkCodecPrintf.

emit_message():
Use libjpeg-turbo’s default implementation of emit_message.

It does not print "trace messages" which essentially are info
messages and it only prints the first warning (unless it a very
serious warning).

Currently, we just print everything, which is why the output
has been so verbose.

BUG=skia:
==========

[msarett, 2015-11-10 19:11:17]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2015-11-10 19:11:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1427523007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1427523007/1

[commit-bot: I haz the power, 2015-11-10 19:22:15]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6dfe9ac3aad3ab8ec3a0f1684c94fef0c6ad9c3e