Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1427433015: Make all the content corner images the same size. (Closed)

Created:
5 years, 1 month ago by Peter Kasting
Modified:
5 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make all the content corner images the same size. Some of these were 38 px high and some 37. They should have all been 38. This bit me when trying to change corner layout to measure a different one of the images' height. It might have also resulted in small gaps in drawing of the content "border"; I didn't look closely. I did check that things are correct with the new images. Since the bottom section of each image is just the same row of pixels over and over, it's easy to expand the height. Did this, then compressed the images with optimize_png_files.sh -o2. BUG=none TEST=none TBR=oshima Committed: https://chromium.googlesource.com/chromium/src/+/839f73c696d017638d755ddb2fec18ee839e06ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/app/theme/default_100_percent/common/content_top_left_corner.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/content_top_left_corner_mask.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/content_top_right_corner.png View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
TBRing for trivial change.
5 years, 1 month ago (2015-11-10 00:38:23 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/839f73c696d017638d755ddb2fec18ee839e06ea Cr-Commit-Position: refs/heads/master@{#358718}
5 years, 1 month ago (2015-11-10 00:42:54 UTC) #2
Peter Kasting
Committed patchset #1 (id:1) manually as 839f73c696d017638d755ddb2fec18ee839e06ea (presubmit successful).
5 years, 1 month ago (2015-11-10 00:43:30 UTC) #3
oshima
5 years, 1 month ago (2015-11-10 00:47:07 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698