Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1427413002: Added --channel argument to run_dev_server_tests. (Closed)

Created:
5 years, 1 month ago by sullivan
Modified:
5 years, 1 month ago
Reviewers:
nduca
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Added --channel argument to run_dev_server_tests. This will be called from the recipe in https://codereview.chromium.org/1428713006 BUG=catapult:#1732 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a84758aa6d75ad364d1266dbc4a9e3a5b21bebc6

Patch Set 1 #

Patch Set 2 : fixed stray prints #

Patch Set 3 : On linux, downgrade canary to dev since there is no canary. Also print which chrome is running. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M catapult_build/run_dev_server_tests.py View 1 2 7 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sullivan
This doesn't actually make the tests run on canary, it just adds an option to ...
5 years, 1 month ago (2015-11-06 04:35:30 UTC) #2
sullivan
Current plan is to submit this CL, and then update the recipe in https://codereview.chromium.org/1428713006 I ...
5 years, 1 month ago (2015-11-06 15:26:53 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427413002/40001
5 years, 1 month ago (2015-11-06 15:37:49 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-06 15:46:00 UTC) #8
nduca
mmm nice lgtm
5 years, 1 month ago (2015-11-06 17:14:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427413002/40001
5 years, 1 month ago (2015-11-06 18:25:50 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 18:32:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698