Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1428713006: Run dev_server tests on both stable and canary channels (Closed)

Created:
5 years, 1 month ago by sullivan
Modified:
5 years, 1 month ago
Reviewers:
nduca
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Run dev_server tests on both stable and canary channels This depends on https://codereview.chromium.org/1427413002/ being submitted first (adding the --channel flag) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -8 lines) Patch
M scripts/slave/recipes/catapult.py View 1 chunk +20 lines, -4 lines 0 comments Download
M scripts/slave/recipes/catapult.expected/basic.json View 2 chunks +30 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sullivan
5 years, 1 month ago (2015-11-06 18:25:57 UTC) #2
nduca
lgtm
5 years, 1 month ago (2015-11-06 18:26:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428713006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428713006/1
5 years, 1 month ago (2015-11-06 20:19:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=297478
5 years, 1 month ago (2015-11-06 20:22:11 UTC) #6
sullivan
5 years, 1 month ago (2015-11-06 21:14:01 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1427583010/ by sullivan@chromium.org.

The reason for reverting is: Some trace-viewer tests are failing on canary:
https://github.com/catapult-project/catapult/issues/1745.

Powered by Google App Engine
This is Rietveld 408576698