Issue 14272005: Fix minor bug in remote_inspector_client.py that broke it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14272005: Fix minor bug in remote_inspector_client.py that broke it. (Closed)

Created:
7 years, 8 months ago by dennis_jeffrey

Modified:
7 years, 8 months ago

Reviewers:
loislo

CC:
chromium-reviews, anantha, dyu1, Dai Mikurube (NOT FULLTIME)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix minor bug in remote_inspector_client.py that broke it. In https://codereview.chromium.org/14058002, the function named _IsWebkitVersionNotOlderThan was changed to _IsContentVersionNotOlderThan. There was one more reference to the old function name in the file that needed to be updated. That is done here. Without this fix, the Chrome Endure tests are broken. BUG=None TEST=Verified that a basic run of a Chrome Endure test failed before this change, but passed after this change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194482

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/pyautolib/remote_inspector_client.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

7 years, 8 months ago (2013-04-16 23:26:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194482 (presubmit successful).

Expand Messages | Collapse Messages