Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
14058002:
Keep remote_inspector_client in sync with the latest changes in Blink. (Closed)
|
Created:
7 years, 8 months ago by loislo Modified:
7 years, 8 months ago CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1 Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionKeep remote_inspector_client in sync with the latest changes in Blink.
We have extracted HeapProfiler domain from Profiler domain.
So the client has to use new agent with fresh version of the browser.
TEST=endurance
BUG=none
R=yurys@chromium.org, dennisjeffrey@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193626
Patch Set 1 #
Total comments: 10
Patch Set 2 : comments addressed #
Total comments: 1
Patch Set 3 : comments addressed #Messages
Total messages: 12 (0 generated)
https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... File chrome/test/pyautolib/remote_inspector_client.py (right): https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... chrome/test/pyautolib/remote_inspector_client.py:285: agent_name): Please add comment for the param. I'd also use something more specific, heap_profiler_agent_name? https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... chrome/test/pyautolib/remote_inspector_client.py:1307: 'Platform': { Content? https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... chrome/test/pyautolib/remote_inspector_client.py:1320: print "%s\n" % result Remove this. https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... chrome/test/pyautolib/remote_inspector_client.py:1344: raise RuntimeError('Platform-Version is not specified.') Platform -> Content https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... chrome/test/pyautolib/remote_inspector_client.py:1348: raise RuntimeError('Platform-Version cannot be parsed.') Platform -> Content
comments addressed https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... File chrome/test/pyautolib/remote_inspector_client.py (right): https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... chrome/test/pyautolib/remote_inspector_client.py:285: agent_name): It is the only agent name at the moment. I don't think that we would have another one. https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... chrome/test/pyautolib/remote_inspector_client.py:1307: 'Platform': { On 2013/04/10 12:42:04, Yury Semikhatsky wrote: > Content? Done. https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... chrome/test/pyautolib/remote_inspector_client.py:1320: print "%s\n" % result On 2013/04/10 12:42:04, Yury Semikhatsky wrote: > Remove this. Done. https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... chrome/test/pyautolib/remote_inspector_client.py:1344: raise RuntimeError('Platform-Version is not specified.') On 2013/04/10 12:42:04, Yury Semikhatsky wrote: > Platform -> Content Done. https://codereview.chromium.org/14058002/diff/1/chrome/test/pyautolib/remote_... chrome/test/pyautolib/remote_inspector_client.py:1348: raise RuntimeError('Platform-Version cannot be parsed.') On 2013/04/10 12:42:04, Yury Semikhatsky wrote: > Platform -> Content Done.
lgtm
LGTM with a nit. Note that we will have to eventually move this file out of its current home in the "pyautolib" folder, since PyAuto has been deprecated and "pyautolib" will eventually be removed from the chrome tree. My only use of the file right now is for the Chrome Endure endurance tests that are implemented in PyAuto, but I'm actively working on migrating those tests to Telemetry. https://codereview.chromium.org/14058002/diff/2003/chrome/test/pyautolib/remo... File chrome/test/pyautolib/remote_inspector_client.py (right): https://codereview.chromium.org/14058002/diff/2003/chrome/test/pyautolib/remo... chrome/test/pyautolib/remote_inspector_client.py:1299: A dictionary containing Brownser and Content version information: Brownser --> Browser
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/14058002/10001
On 2013/04/10 17:21:34, dennis_jeffrey wrote: > LGTM with a nit. > > Note that we will have to eventually move this file out of its current home in > the "pyautolib" folder, since PyAuto has been deprecated and "pyautolib" will > eventually be removed from the chrome tree. My only use of the file right now > is for the Chrome Endure endurance tests that are implemented in PyAuto, but I'm > actively working on migrating those tests to Telemetry. > We have several devtools functional tests that depend on this file (chrome/test/functional/devtools_*) which should also be migrated to Telemetry. When are you planning to move this file out of chrome?
jsleakcheck also depends on this file. Is Telemetry going to offer the same functionality, like taking heap snapshots?
Sorry for I got bad news for ya. Compile failed with a clobber build on win7_aura. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&... Your code is likely broken or HEAD is junk. Please ensure your code is not broken then alert the build sheriffs. Look at the try server FAQ for more details.
Message was sent while issue was closed.
Committed patchset #3 manually as r193626 (presubmit successful).
On Thu, Apr 11, 2013 at 1:53 AM, <marja@chromium.org> wrote: > jsleakcheck also depends on this file. Is Telemetry going to offer the same > functionality, like taking heap snapshots? > > It should be possible since Telemetry is built on top of DevTools. In fact, I've already moved one small part of this file over to Telemetry, which is the part about getting DOM node counts ( https://chromiumcodereview.appspot.com/12800004/). We just have to send the right requests into DevTools from Telemetry. However, worst-case we can just move this file to another location in the chrome tree and keep using it, once the "pyautolib" folder has to go away. > https://codereview.chromium.**org/14058002/<https://codereview.chromium.org/1... >
On Thu, Apr 11, 2013 at 1:28 AM, <yurys@chromium.org> wrote: > On 2013/04/10 17:21:34, dennis_jeffrey wrote: > >> LGTM with a nit. >> > > Note that we will have to eventually move this file out of its current >> home in >> the "pyautolib" folder, since PyAuto has been deprecated and "pyautolib" >> will >> eventually be removed from the chrome tree. My only use of the file >> right now >> is for the Chrome Endure endurance tests that are implemented in PyAuto, >> but >> > I'm > >> actively working on migrating those tests to Telemetry. >> > > We have several devtools functional tests that depend on this file > (chrome/test/functional/**devtools_*) which should also be migrated to > Telemetry. > When are you planning to move this file out of chrome? > > This file will likely have to be removed (or just moved to another home in the chrome tree) as soon as PyAuto itself is removed from the chrome tree. There's a bug tracking that here: https://code.google.com/p/chromium/issues/detail?id=224072 Current plan is to remove PyAuto by the end of the quarter. Part of doing that will likely be removing the "pyautolib" folder that contains the current file. > > > https://codereview.chromium.**org/14058002/<https://codereview.chromium.org/1... > |
