Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1427163004: win: Add CrashpadClient::GetHandlerIPCPipe() (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Add CrashpadClient::GetHandlerIPCPipe() For multiprocess architectures, this method allows the pipe used for registration to be obtained from CrashpadHandler, even when CrashpadHandler chooses its own name. This may happen if the handler is not running on a well-known pipe name but was instead started by CrashpadHandler::StartHandler(). If Chrome uses this interface, for example, the browser process will need to call CrashpadClient::GetHandlerIPCPipe() and pass the pipe name to its child processes. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a30db914afae7904237b9ccd9576828808868f34

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M client/crashpad_client.h View 1 1 chunk +16 lines, -5 lines 0 comments Download
M client/crashpad_client_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
5 years, 1 month ago (2015-11-02 22:11:44 UTC) #2
scottmg
lgtm https://codereview.chromium.org/1427163004/diff/1/client/crashpad_client.h File client/crashpad_client.h (right): https://codereview.chromium.org/1427163004/diff/1/client/crashpad_client.h#newcode81 client/crashpad_client.h:81: //! The IPC pipe name (somehow) encodes enough ...
5 years, 1 month ago (2015-11-02 22:15:40 UTC) #3
Mark Mentovai
https://codereview.chromium.org/1427163004/diff/1/client/crashpad_client.h File client/crashpad_client.h (right): https://codereview.chromium.org/1427163004/diff/1/client/crashpad_client.h#newcode81 client/crashpad_client.h:81: //! The IPC pipe name (somehow) encodes enough information ...
5 years, 1 month ago (2015-11-03 00:08:46 UTC) #4
Mark Mentovai
5 years, 1 month ago (2015-11-03 04:15:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a30db914afae7904237b9ccd9576828808868f34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698