Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: client/crashpad_client.h

Issue 1427163004: win: Add CrashpadClient::GetHandlerIPCPipe() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/crashpad_client_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crashpad_client.h
diff --git a/client/crashpad_client.h b/client/crashpad_client.h
index d3d7e347ba5d4ecb345a936fd68fef45df5405cf..18b7b13191b8df7231a448a57538d1c705b1a068 100644
--- a/client/crashpad_client.h
+++ b/client/crashpad_client.h
@@ -72,22 +72,33 @@ class CrashpadClient {
const std::vector<std::string>& arguments);
#if defined(OS_WIN) || DOXYGEN
- //! \brief Sets the IPC port of a presumably-running Crashpad handler process
+ //! \brief Sets the IPC pipe of a presumably-running Crashpad handler process
//! which was started with StartHandler() or by other compatible means
//! and does an IPC message exchange to register this process with the
//! handler. However, just like StartHandler(), crashes are not serviced
//! until UseHandler() is called.
//!
- //! The IPC port name (somehow) encodes enough information so that
- //! registration is done with a crash handler using the appropriate database
- //! and upload server.
- //!
//! \param[in] ipc_pipe The full name of the crash handler IPC pipe. This is
//! a string of the form `&quot;\\.\pipe\NAME&quot;`.
//!
//! \return `true` on success and `false` on failure.
bool SetHandlerIPCPipe(const std::wstring& ipc_pipe);
+ //! \brief Retrieves the IPC pipe name used to register with the Crashpad
+ //! handler.
+ //!
+ //! This method retrieves the IPC pipe name set by SetHandlerIPCPipe(), or a
+ //! suitable IPC pipe name chosen by StartHandler(). It is intended to be used
+ //! to obtain the IPC pipe name so that it may be passed to other processes,
+ //! so that they may register with an existing Crashpad handler by calling
+ //! SetHandlerIPCPipe().
+ //!
+ //! This method is only defined on Windows.
+ //!
+ //! \return The full name of the crash handler IPC pipe, a string of the form
+ //! `&quot;\\.\pipe\NAME&quot;`.
+ std::wstring GetHandlerIPCPipe() const;
+
//! \brief Requests that the handler capture a dump even though there hasn't
//! been a crash.
//!
« no previous file with comments | « no previous file | client/crashpad_client_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698