src/objects.h - Issue 1427113002: Fix corner-case behavior of Object::SetSuperProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 1427113002: Fix corner-case behavior of Object::SetSuperProperty. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 127daddb074f6fa64304f2123501610aee978508..f2ccafbb343cfec574bd1a4b1dfffe0984cef0b2 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -1271,7 +1271,7 @@ class Object {

MUST_USE_RESULT static Maybe<bool> WriteToReadOnlyProperty(

Isolate* isolate, Handle<Object> receiver, Handle<Object> name,

Handle<Object> value, ShouldThrow should_throw);

- MUST_USE_RESULT static Maybe<bool> RedefineNonconfigurableProperty(

+ MUST_USE_RESULT static Maybe<bool> RedefineIncompatibleProperty(

Isolate* isolate, Handle<Object> name, Handle<Object> value,

ShouldThrow should_throw);

MUST_USE_RESULT static Maybe<bool> SetDataProperty(LookupIterator* it,

« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')