Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/objects.h

Issue 1427113002: Fix corner-case behavior of Object::SetSuperProperty. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 1253 matching lines...) Expand 10 before | Expand all | Expand 10 after
1264 Isolate* isolate, Handle<Object> receiver, Handle<Object> name, 1264 Isolate* isolate, Handle<Object> receiver, Handle<Object> name,
1265 LanguageMode language_mode); 1265 LanguageMode language_mode);
1266 MUST_USE_RESULT static Maybe<bool> CannotCreateProperty( 1266 MUST_USE_RESULT static Maybe<bool> CannotCreateProperty(
1267 Isolate* isolate, Handle<Object> receiver, Handle<Object> name, 1267 Isolate* isolate, Handle<Object> receiver, Handle<Object> name,
1268 Handle<Object> value, ShouldThrow should_throw); 1268 Handle<Object> value, ShouldThrow should_throw);
1269 MUST_USE_RESULT static Maybe<bool> WriteToReadOnlyProperty( 1269 MUST_USE_RESULT static Maybe<bool> WriteToReadOnlyProperty(
1270 LookupIterator* it, Handle<Object> value, ShouldThrow should_throw); 1270 LookupIterator* it, Handle<Object> value, ShouldThrow should_throw);
1271 MUST_USE_RESULT static Maybe<bool> WriteToReadOnlyProperty( 1271 MUST_USE_RESULT static Maybe<bool> WriteToReadOnlyProperty(
1272 Isolate* isolate, Handle<Object> receiver, Handle<Object> name, 1272 Isolate* isolate, Handle<Object> receiver, Handle<Object> name,
1273 Handle<Object> value, ShouldThrow should_throw); 1273 Handle<Object> value, ShouldThrow should_throw);
1274 MUST_USE_RESULT static Maybe<bool> RedefineNonconfigurableProperty( 1274 MUST_USE_RESULT static Maybe<bool> RedefineIncompatibleProperty(
1275 Isolate* isolate, Handle<Object> name, Handle<Object> value, 1275 Isolate* isolate, Handle<Object> name, Handle<Object> value,
1276 ShouldThrow should_throw); 1276 ShouldThrow should_throw);
1277 MUST_USE_RESULT static Maybe<bool> SetDataProperty(LookupIterator* it, 1277 MUST_USE_RESULT static Maybe<bool> SetDataProperty(LookupIterator* it,
1278 Handle<Object> value, 1278 Handle<Object> value,
1279 ShouldThrow should_throw); 1279 ShouldThrow should_throw);
1280 MUST_USE_RESULT static Maybe<bool> AddDataProperty( 1280 MUST_USE_RESULT static Maybe<bool> AddDataProperty(
1281 LookupIterator* it, Handle<Object> value, PropertyAttributes attributes, 1281 LookupIterator* it, Handle<Object> value, PropertyAttributes attributes,
1282 ShouldThrow should_throw, StoreFromKeyed store_mode); 1282 ShouldThrow should_throw, StoreFromKeyed store_mode);
1283 MUST_USE_RESULT static inline MaybeHandle<Object> GetPropertyOrElement( 1283 MUST_USE_RESULT static inline MaybeHandle<Object> GetPropertyOrElement(
1284 Handle<Object> object, Handle<Name> name, 1284 Handle<Object> object, Handle<Name> name,
(...skipping 9544 matching lines...) Expand 10 before | Expand all | Expand 10 after
10829 // (elements + properties) in the current level. 10829 // (elements + properties) in the current level.
10830 int levelLength_ = 0; 10830 int levelLength_ = 0;
10831 10831
10832 DISALLOW_COPY_AND_ASSIGN(KeyAccumulator); 10832 DISALLOW_COPY_AND_ASSIGN(KeyAccumulator);
10833 }; 10833 };
10834 10834
10835 } // NOLINT, false-positive due to second-order macros. 10835 } // NOLINT, false-positive due to second-order macros.
10836 } // NOLINT, false-positive due to second-order macros. 10836 } // NOLINT, false-positive due to second-order macros.
10837 10837
10838 #endif // V8_OBJECTS_H_ 10838 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698