Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1427113002: Fix corner-case behavior of Object::SetSuperProperty. (Closed)

Created:
5 years, 1 month ago by neis
Modified:
5 years, 1 month ago
Reviewers:
rossberg, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix corner-case behavior of Object::SetSuperProperty. When the property is an accessor property in the receiver but not on the holder (ES6 "target"), we must fail. R=rossberg, verwaest@chromium.org BUG= Committed: https://crrev.com/8c1377a5b4ef3b88610d638ae989072a154e8b90 Cr-Commit-Position: refs/heads/master@{#31733}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -72 lines) Patch
M src/objects.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 6 chunks +15 lines, -18 lines 0 comments Download
M test/mjsunit/es6/super.js View 6 chunks +22 lines, -48 lines 0 comments Download
M test/mjsunit/harmony/reflect.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
neis
5 years, 1 month ago (2015-10-30 14:22:01 UTC) #1
rossberg
lgtm
5 years, 1 month ago (2015-10-30 14:26:48 UTC) #2
Toon Verwaest
https://codereview.chromium.org/1427113002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1427113002/diff/1/src/objects.cc#newcode3769 src/objects.cc:3769: if (details.IsConfigurable() || !details.IsReadOnly()) { step 5.e.ii of 9.1.9 ...
5 years, 1 month ago (2015-11-02 09:28:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427113002/20001
5 years, 1 month ago (2015-11-03 07:45:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 08:04:06 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 08:04:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c1377a5b4ef3b88610d638ae989072a154e8b90
Cr-Commit-Position: refs/heads/master@{#31733}

Powered by Google App Engine
This is Rietveld 408576698