Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: test/mjsunit/harmony/reflect.js

Issue 1427113002: Fix corner-case behavior of Object::SetSuperProperty. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/es6/super.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/reflect.js
diff --git a/test/mjsunit/harmony/reflect.js b/test/mjsunit/harmony/reflect.js
index e61b65e14318931333de18b785da0cbb1ed51961..439c38f0b5c122325aa33b0cbdf2db729f961a76 100644
--- a/test/mjsunit/harmony/reflect.js
+++ b/test/mjsunit/harmony/reflect.js
@@ -248,11 +248,10 @@ function prepare(target) {
// assertFalse(Reflect.set({}, "nowrite", value, target));
// Data vs Accessor
- // TODO(neis): These must return false but currently don't.
- // assertFalse(Reflect.set(target, "unknown", value, {set bla(x) {}}));
- // assertFalse(Reflect.set(target, "unknown", value, {get bla() {}}));
- // assertFalse(Reflect.set(target, "bla", value, {set bla(x) {}}));
- // assertFalse(Reflect.set(target, "bla", value, {get bla() {}}));
+ assertFalse(Reflect.set({}, "unknown", 0, {set unknown(x) {}}));
+ assertFalse(Reflect.set(target, "unknown", value, {set unknown(x) {}}));
+ assertFalse(Reflect.set(target, "bla", value, {set bla(x) {}}));
+ assertFalse(Reflect.set(target, "bla", value, {get bla() {}}));
// Accessor vs Data
assertTrue(Reflect.set({set bla(x) {}}), "bla", value, target);
« no previous file with comments | « test/mjsunit/es6/super.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698