Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 1426943007: Revert of "[es6] Partially implement Reflect.ownKeys." (Closed)

Created:
5 years, 1 month ago by neis
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of "[es6] Partially implement Reflect.ownKeys." Reason for revert: failed tests on a Windows build. TBR=rossberg,cbruni,neis NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ec0f891d1ee31a6c22217dbb80db33ebff87f618 Cr-Commit-Position: refs/heads/master@{#31907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -164 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/objects.cc View 5 chunks +5 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/reflect.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/mjsunit/harmony/reflect-own-keys.js View 1 chunk +0 lines, -93 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426943007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426943007/1
5 years, 1 month ago (2015-11-10 00:05:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 00:05:11 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 00:05:29 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec0f891d1ee31a6c22217dbb80db33ebff87f618
Cr-Commit-Position: refs/heads/master@{#31907}

Powered by Google App Engine
This is Rietveld 408576698