Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: src/builtins.cc

Issue 1426943007: Revert of "[es6] Partially implement Reflect.ownKeys." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index 15d53c873a47c746d7c818dc1c67a523e931a3a9..7695ccc753f731932de907b74bced1951eace638 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -1640,29 +1640,6 @@ BUILTIN(ReflectIsExtensible) {
}
-// ES6 section 26.1.11 Reflect.ownKeys
-BUILTIN(ReflectOwnKeys) {
- HandleScope scope(isolate);
- DCHECK_EQ(2, args.length());
- Handle<Object> target = args.at<Object>(1);
-
- if (!target->IsJSReceiver()) {
- THROW_NEW_ERROR_RETURN_FAILURE(
- isolate, NewTypeError(MessageTemplate::kCalledOnNonObject,
- isolate->factory()->NewStringFromAsciiChecked(
- "Reflect.ownKeys")));
- }
-
- Handle<FixedArray> keys;
- ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
- isolate, keys,
- JSReceiver::GetKeys(Handle<JSReceiver>::cast(target),
- JSReceiver::OWN_ONLY, INCLUDE_SYMBOLS,
- CONVERT_TO_STRING, IGNORE_ENUMERABILITY));
- return *isolate->factory()->NewJSArrayWithElements(keys);
-}
-
-
// ES6 section 26.1.12 Reflect.preventExtensions
BUILTIN(ReflectPreventExtensions) {
HandleScope scope(isolate);
« no previous file with comments | « src/builtins.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698