Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1426933003: Subzero: Force ebp-based frame when an alloca has a large alignment. (Closed)

Created:
5 years, 1 month ago by Jim Stichnoth
Modified:
5 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Force ebp-based frame when an alloca has a large alignment. If the alloca alignment exceeds the known ABI stack alignment, the lowering sequence adds an "and esp, xxx" instruction. In this case, the esp adjustment is no longer statically known, so we must force an ebp-based frame. BUG= none R=sehr@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8686139f458786afd21f59aedbb2debabcdff803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 5 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jim Stichnoth
As might be expected, spec2k was unaffected by this bug.
5 years, 1 month ago (2015-10-31 14:44:14 UTC) #3
sehr (please use chromium)
LGTM, and thanks!
5 years, 1 month ago (2015-10-31 18:16:13 UTC) #4
Jim Stichnoth
5 years, 1 month ago (2015-10-31 19:55:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8686139f458786afd21f59aedbb2debabcdff803 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698