src/IceTargetLoweringX86BaseImpl.h - Issue 1426933003: Subzero: Force ebp-based frame when an alloca has a large alignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX86BaseImpl.h

Issue 1426933003: Subzero: Force ebp-based frame when an alloca has a large alignment. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX86BaseImpl.h

diff --git a/src/IceTargetLoweringX86BaseImpl.h b/src/IceTargetLoweringX86BaseImpl.h

index 1ad9b2941799f01b340cbfff45cbe1d9f6ea2775..b6b54e397d6fd1be0f638a84692485ca8810de91 100644

--- a/src/IceTargetLoweringX86BaseImpl.h

+++ b/src/IceTargetLoweringX86BaseImpl.h

@@ -956,6 +956,7 @@ void TargetX86Base<Machine>::lowerAlloca(const InstAlloca *Inst) {

uint32_t Alignment =

std::max(AlignmentParam, Traits::X86_STACK_ALIGNMENT_BYTES);

if (Alignment > Traits::X86_STACK_ALIGNMENT_BYTES) {

+ IsEbpBasedFrame = true;

_and(esp, Ctx->getConstantInt32(-Alignment));

}

if (const auto *ConstantTotalSize =

« no previous file with comments | « no previous file | tests_lit/llvm2ice_tests/alloc.ll » ('j') | no next file with comments »