gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc - Issue 1426903002: gpu: Make glTexSubImage2D work with GL_SRGB_ALPHA on OpenGL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

Issue 1426903002: gpu: Make glTexSubImage2D work with GL_SRGB_ALPHA on OpenGL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/texture_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

index 4a8f9cfb6e265020e32f1f3c45bc0d030baaba16..37d377dfff3de184f91cbe120d04b08e3bf4b05f 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

@@ -219,8 +219,8 @@ TEST_P(GLES2DecoderTest, TexSubImage2DValidArgs) {

}

TEST_P(GLES2DecoderTest, TexSubImage2DBadArgs) {

- const int kWidth = 16;

- const int kHeight = 8;

+ const int kWidth = 8;

+ const int kHeight = 4;

bajones 2015/10/28 20:23:26 What necessitated this change?

Kimmo Kinnunen 2015/10/29 06:21:17 Explained already in the commit message. The data

DoBindTexture(GL_TEXTURE_2D, client_texture_id_, kServiceTextureId);

DoTexImage2D(GL_TEXTURE_2D,