gpu: Make glTexSubImage2D work with GL_SRGB_ALPHA on OpenGL

gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
 #include "gpu/command_buffer/common/gles2_cmd_format.h"
 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
@@ skipping 201 matching lines @@
            GL_RGBA,
            GL_UNSIGNED_BYTE,
            kSharedMemoryId,
            kSharedMemoryOffset,
            GL_FALSE);
   EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
   EXPECT_EQ(GL_NO_ERROR, GetGLError());
 }
 
 TEST_P(GLES2DecoderTest, TexSubImage2DBadArgs) {
-  const int kWidth = 16;
-  const int kHeight = 8;
+  const int kWidth = 8;
+  const int kHeight = 4;

[bajones, 2015/10/28 20:23:26]

What necessitated this change?

[Kimmo Kinnunen, 2015/10/29 06:21:17]

Explained already in the commit message. The data length of one of the test
cases exceeds unit test shm size, and kOutOfBounds is returned before an
validation error (16*8*4 components*4 bytes per component in gl_unsigned_int ==
2048). 

   DoBindTexture(GL_TEXTURE_2D, client_texture_id_, kServiceTextureId);
   DoTexImage2D(GL_TEXTURE_2D,
                1,
                GL_RGBA,
                kWidth,
                kHeight,
                0,
                GL_RGBA,
                GL_UNSIGNED_BYTE,
                0,
@@ skipping 25 matching lines @@
            GL_FALSE);
   EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
   EXPECT_EQ(GL_INVALID_ENUM, GetGLError());
   cmd.Init(GL_TEXTURE_2D,
            1,
            0,
            0,
            kWidth,
            kHeight,
            GL_RGBA,
            GL_UNSIGNED_INT,

[Kimmo Kinnunen, 2015/10/29 06:21:17]

This is the case that would fail with oob when the "!pixels" check is moved
before validation.

            kSharedMemoryId,
            kSharedMemoryOffset,
            GL_FALSE);
   EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
   EXPECT_EQ(GL_INVALID_ENUM, GetGLError());
   cmd.Init(GL_TEXTURE_2D,
            1,
            -1,
            0,
            kWidth,
@@ skipping 3083 matching lines @@
 // TODO(gman): CompressedTexSubImage2DImmediate
 
 // TODO(gman): TexImage2D
 
 // TODO(gman): TexImage2DImmediate
 
 // TODO(gman): TexSubImage2DImmediate
 
 }  // namespace gles2
 }  // namespace gpu