Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1426863005: [Interpreter] Ensure we save the BytecodeArray register properly in InterpreterEntryTrampoline buil… (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Ensure we save the BytecodeArray register properly in InterpreterEntryTrampoline builtin. Ensure that we save the BytecodeArray register in the InterpreterEntryTrampoline before calling out to the kStackGuard runtime function. BUG=v8:4280 LOG=N Committed: https://crrev.com/76d730b9b2012cbe24b0a62f465deac222f098ad Cr-Commit-Position: refs/heads/master@{#31650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426863005/1
5 years, 1 month ago (2015-10-28 12:45:18 UTC) #2
rmcilroy
5 years, 1 month ago (2015-10-28 12:45:41 UTC) #4
rmcilroy
Benedikt, could you take a look please?
5 years, 1 month ago (2015-10-28 12:45:56 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-28 13:23:22 UTC) #7
Benedikt Meurer
LGTM.
5 years, 1 month ago (2015-10-29 10:16:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426863005/1
5 years, 1 month ago (2015-10-29 10:57:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 11:47:09 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 11:47:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76d730b9b2012cbe24b0a62f465deac222f098ad
Cr-Commit-Position: refs/heads/master@{#31650}

Powered by Google App Engine
This is Rietveld 408576698