Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1413863010: [Interpreter] Add wide varients of bytecodes with feedback and constant pool indexes. (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
oth, Michael Starzinger
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_fixbuiltinstacklimit
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add wide varients of bytecodes with feedback and constant pool indexes. Adds wide bytecode varients, which take 16-bit feedback slot and constant pool entry indexes for the following bytecodes: - LoadICSloppyWide - LoadICStrictWide - KeyedLoadICSloppyWide - KeyedLoadICStrictWide - StoreICSloppyWide - StoreICStrictWide - KeyedStoreICSloppyWide - KeyedStoreICStrictWide - LdaGlobalSloppyWide - LdaGlobalStrictWide - StaGlobalSloppyWide - StaGlobalStrictWide - LdaConstantWide BUG=v8:4280 LOG=N Committed: https://crrev.com/6173d504ee625c19a64fc0521fa918aa4e0947a0 Cr-Commit-Position: refs/heads/master@{#31683}

Patch Set 1 : #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+758 lines, -133 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 5 chunks +78 lines, -0 lines 0 comments Download
M src/compiler/interpreter-assembler.h View 1 1 chunk +4 lines, -8 lines 0 comments Download
M src/compiler/interpreter-assembler.cc View 1 1 chunk +19 lines, -14 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 9 chunks +66 lines, -0 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 3 chunks +22 lines, -1 line 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 39 chunks +222 lines, -63 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 21 chunks +314 lines, -42 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 3 chunks +23 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413863010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413863010/20001
5 years, 1 month ago (2015-10-29 10:05:39 UTC) #4
rmcilroy
Orion, PTAL at interpreter changes. Michi, PTAL at the compiler changes. Thanks.
5 years, 1 month ago (2015-10-29 10:06:39 UTC) #6
Michael Starzinger
LGTM from my end.
5 years, 1 month ago (2015-10-29 12:13:35 UTC) #8
oth
lgtm
5 years, 1 month ago (2015-10-30 10:26:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413863010/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413863010/60001
5 years, 1 month ago (2015-10-30 10:46:58 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 1 month ago (2015-10-30 11:17:11 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 11:17:41 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6173d504ee625c19a64fc0521fa918aa4e0947a0
Cr-Commit-Position: refs/heads/master@{#31683}

Powered by Google App Engine
This is Rietveld 408576698