| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Presubmit script for changes affecting extensions. | 5 """Presubmit script for changes affecting extensions. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 import fnmatch | 10 import fnmatch |
| (...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 85 if not os.path.exists(name): | 85 if not os.path.exists(name): |
| 86 continue | 86 continue |
| 87 if (fnmatch.fnmatch(name, '*%s*' % INTROS_PATH) or | 87 if (fnmatch.fnmatch(name, '*%s*' % INTROS_PATH) or |
| 88 fnmatch.fnmatch(name, '*%s*' % ARTICLES_PATH)): | 88 fnmatch.fnmatch(name, '*%s*' % ARTICLES_PATH)): |
| 89 contents = input_api.ReadFile(name) | 89 contents = input_api.ReadFile(name) |
| 90 if (len(re.findall(headings_re, contents)) != | 90 if (len(re.findall(headings_re, contents)) != |
| 91 len(re.findall(ids_re, contents))): | 91 len(re.findall(ids_re, contents))): |
| 92 bad_files.append(name) | 92 bad_files.append(name) |
| 93 return bad_files | 93 return bad_files |
| 94 | 94 |
| 95 def _CheckVersions(input_api, output_api, results): | |
| 96 version = '_VERSION =' | |
| 97 for affected_file in input_api.AffectedFiles(): | |
| 98 local_path = affected_file.LocalPath() | |
| 99 if not fnmatch.fnmatch(local_path, '%s*' % SERVER2_PATH): | |
| 100 continue | |
| 101 if local_path.endswith('PRESUBMIT.py'): | |
| 102 continue | |
| 103 if any(version in line for line in affected_file.NewContents()): | |
| 104 found = False | |
| 105 for _, text in affected_file.ChangedContents(): | |
| 106 if version in text: | |
| 107 found = True | |
| 108 break | |
| 109 if not found: | |
| 110 results.append(output_api.PresubmitPromptWarning( | |
| 111 '_VERSION of %s needs to be incremented.' % affected_file)) | |
| 112 | |
| 113 def _CheckLinks(input_api, output_api, results): | 95 def _CheckLinks(input_api, output_api, results): |
| 114 for affected_file in input_api.AffectedFiles(): | 96 for affected_file in input_api.AffectedFiles(): |
| 115 name = affected_file.LocalPath() | 97 name = affected_file.LocalPath() |
| 116 absolute_path = affected_file.AbsoluteLocalPath() | 98 absolute_path = affected_file.AbsoluteLocalPath() |
| 117 if not os.path.exists(absolute_path): | 99 if not os.path.exists(absolute_path): |
| 118 continue | 100 continue |
| 119 if (fnmatch.fnmatch(name, '%s*' % PUBLIC_TEMPLATES_PATH) or | 101 if (fnmatch.fnmatch(name, '%s*' % PUBLIC_TEMPLATES_PATH) or |
| 120 fnmatch.fnmatch(name, '%s*' % INTROS_PATH) or | 102 fnmatch.fnmatch(name, '%s*' % INTROS_PATH) or |
| 121 fnmatch.fnmatch(name, '%s*' % ARTICLES_PATH) or | 103 fnmatch.fnmatch(name, '%s*' % ARTICLES_PATH) or |
| 122 fnmatch.fnmatch(name, '%s*' % API_PATH)): | 104 fnmatch.fnmatch(name, '%s*' % API_PATH)): |
| (...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 164 results.append(output_api.PresubmitError('IntegrationTest failed!')) | 146 results.append(output_api.PresubmitError('IntegrationTest failed!')) |
| 165 _CheckVersions(input_api, output_api, results) | 147 _CheckVersions(input_api, output_api, results) |
| 166 _CheckLinks(input_api, output_api, results) | 148 _CheckLinks(input_api, output_api, results) |
| 167 return results | 149 return results |
| 168 | 150 |
| 169 def CheckChangeOnUpload(input_api, output_api): | 151 def CheckChangeOnUpload(input_api, output_api): |
| 170 return _CheckChange(input_api, output_api) | 152 return _CheckChange(input_api, output_api) |
| 171 | 153 |
| 172 def CheckChangeOnCommit(input_api, output_api): | 154 def CheckChangeOnCommit(input_api, output_api): |
| 173 return _CheckChange(input_api, output_api) | 155 return _CheckChange(input_api, output_api) |
| OLD | NEW |