Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 14267014: [win] Explicitly hide the bubble widget after creation. (Closed)

Created:
7 years, 8 months ago by tapted
Modified:
7 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[win] Explicitly hide the bubble widget after creation. This is to explicitly set the SWP_HIDEWINDOW flag which it seems Windows might not set by default on future WM_WINDOWPOSCHANGED messages. Potentially resulting in the border widget being shown without the bubble contents. BUG=231687 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ui/app_list/views/app_list_view.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tapted
Hi xiyuan, could you take a look? This is a somewhat speculative fix, but it ...
7 years, 8 months ago (2013-04-19 11:34:34 UTC) #1
xiyuan
LGTM
7 years, 8 months ago (2013-04-19 16:02:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/14267014/1
7 years, 8 months ago (2013-04-19 22:33:08 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 02:00:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/14267014/1
7 years, 8 months ago (2013-04-21 23:06:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/14267014/1
7 years, 8 months ago (2013-04-21 23:07:10 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-21 23:30:32 UTC) #7
tapted
7 years, 8 months ago (2013-04-22 02:07:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r195431 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698