Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: ui/app_list/views/app_list_view.cc

Issue 14267014: [win] Explicitly hide the bubble widget after creation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/app_list_view.cc
diff --git a/ui/app_list/views/app_list_view.cc b/ui/app_list/views/app_list_view.cc
index 1ddb9587a8fbb2ec73f13199d756ee90508bc5e5..b63cc27f6b0098f8e1087cedc827ecb837a01d90 100644
--- a/ui/app_list/views/app_list_view.cc
+++ b/ui/app_list/views/app_list_view.cc
@@ -107,6 +107,13 @@ void AppListView::InitAsBubble(gfx::NativeView parent,
set_background(new AppListBackground(
GetBubbleFrameView()->bubble_border()->GetBorderCornerRadius(),
app_list_main_view_->search_box_view()));
+
+ // On non-aura the bubble has two widgets, and it's possible for the border
+ // to be shown independently in odd situations. Explicitly hide the bubble
+ // widget to ensure that any WM_WINDOWPOSCHANGED messages triggered by the
+ // window manager do not have the SWP_SHOWWINDOW flag set which would cause
+ // the border to be shown. See http://crbug.com/231687 .
+ GetWidget()->Hide();
#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698