Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1426673009: Log UMA for navigation start timestamp skew for browser-initiated loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation_start_renderer
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index a5b6f8f4edeb4ce5b64324100aab94298fabb355..b9d5253abcfb5e4180df10a95142b89347ffe029 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -20778,6 +20778,32 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Navigation.Start.RendererBrowserDifference.Negative"
+ units="milliseconds">
+ <owner>csharrison@chromium.org</owner>
+ <summary>
+ The difference between Now() in the renderer and browser_navigation_start
+ for browser-initiated navigations if the difference is negative. This value
+ should ideally only reflect the IPC time between the browser process and
clamy 2015/11/06 10:58:51 On transfer navigations, this difference covers mo
Charlie Harrison 2015/11/06 13:35:19 Huh, I could have sworn that this comment included
clamy 2015/11/06 14:07:02 transferred_request_request_id != -1 identifies a
Charlie Harrison 2015/11/06 14:42:35 Ah okay thanks for the clarification, I was confla
+ renderer process, but in practice could be skewed by inter-process timing
+ errors. If the clocks used for TimeTicks are monotonic across processes, all
+ samples should fall into the Positive bucket.
+ </summary>
+</histogram>
+
+<histogram name="Navigation.Start.RendererBrowserDifference.Positive"
+ units="milliseconds">
+ <owner>csharrison@chromium.org</owner>
+ <summary>
+ The difference between Now() in the renderer and browser_navigation_start
+ for browser-initiated navigations if the difference is positive. This value
+ should ideally only reflect the IPC time between the browser process and
+ renderer process, but in practice could be skewed by inter-process timing
+ errors. If the clocks used for TimeTicks are monotonic across processes, all
+ samples should fall into the Positive bucket.
+ </summary>
+</histogram>
+
<histogram name="Navigation.TimeToCommit" units="milliseconds">
<owner>carlosk@chromium.org</owner>
<summary>
« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_frame_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698