Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2961)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1426673009: Log UMA for navigation start timestamp skew for browser-initiated loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation_start_renderer
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 6f08693d2fbfb13d5200a140879e5bc08bda2b4b..8e60f8f04a849469a6c885cb03f945715b36569a 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -475,9 +475,19 @@ base::TimeTicks SanitizeNavigationTiming(
DCHECK(!browser_navigation_start.is_null());
base::TimeTicks navigation_start =
std::min(browser_navigation_start, renderer_navigation_start);
- // TODO(csharrison) Investigate how big a problem the cross process
- // monotonicity really is and on what platforms. Log UMA for:
- // |renderer_navigation_start - browser_navigation_start|
+ base::TimeDelta difference =
+ renderer_navigation_start - browser_navigation_start;
+ if (difference > base::TimeDelta()) {
+ UMA_HISTOGRAM_CUSTOM_TIMES(
+ "Navigation.Start.RendererBrowserDifference.Positive", difference,
+ base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromSeconds(5),
Alexei Svitkine (slow) 2015/11/06 16:53:18 Suggest using UMA_HISTOGRAM_TIMES(). It gives you
+ 50);
+ } else {
+ UMA_HISTOGRAM_CUSTOM_TIMES(
+ "Navigation.Start.RendererBrowserDifference.Negative", -difference,
+ base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromSeconds(5),
+ 50);
+ }
return navigation_start;
}
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698