Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 142663004: Reverts refactoring of CPU feature detection for (Closed)

Created:
6 years, 10 months ago by zra
Modified:
6 years, 10 months ago
Reviewers:
vsm, iposva, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reverts refactoring of CPU feature detection for assertion failure in Dartium. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -1128 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +20 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 4 chunks +93 lines, -3 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 57 chunks +60 lines, -61 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 1 chunk +19 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 6 chunks +57 lines, -5 lines 0 comments Download
M runtime/vm/assembler_ia32_test.cc View 9 chunks +8 lines, -9 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 2 chunks +47 lines, -1 line 0 comments Download
M runtime/vm/cpu.h View 1 chunk +0 lines, -13 lines 0 comments Download
D runtime/vm/cpu_arm.h View 1 chunk +0 lines, -76 lines 0 comments Download
M runtime/vm/cpu_arm.cc View 2 chunks +2 lines, -51 lines 0 comments Download
D runtime/vm/cpu_ia32.h View 1 chunk +0 lines, -61 lines 0 comments Download
M runtime/vm/cpu_ia32.cc View 2 chunks +1 line, -32 lines 0 comments Download
D runtime/vm/cpu_mips.h View 1 chunk +0 lines, -43 lines 0 comments Download
M runtime/vm/cpu_mips.cc View 2 chunks +2 lines, -33 lines 0 comments Download
D runtime/vm/cpu_x64.h View 1 chunk +0 lines, -61 lines 0 comments Download
M runtime/vm/cpu_x64.cc View 2 chunks +0 lines, -28 lines 0 comments Download
D runtime/vm/cpuinfo.h View 1 chunk +0 lines, -69 lines 0 comments Download
D runtime/vm/cpuinfo_android.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D runtime/vm/cpuinfo_linux.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D runtime/vm/cpuinfo_macos.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D runtime/vm/cpuinfo_test.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D runtime/vm/cpuinfo_win.cc View 1 chunk +0 lines, -115 lines 0 comments Download
M runtime/vm/dart.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
6 years, 10 months ago (2014-02-11 15:31:02 UTC) #1
siva
lgtm
6 years, 10 months ago (2014-02-11 15:34:53 UTC) #2
zra
6 years, 10 months ago (2014-02-11 16:05:53 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r32560 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698