Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: runtime/vm/dart.cc

Issue 142663004: Reverts refactoring of CPU feature detection for (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/cpuinfo_win.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/code_observers.h" 7 #include "vm/code_observers.h"
8 #include "vm/cpu.h"
9 #include "vm/dart_api_state.h" 8 #include "vm/dart_api_state.h"
10 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
11 #include "vm/flags.h" 10 #include "vm/flags.h"
12 #include "vm/freelist.h" 11 #include "vm/freelist.h"
13 #include "vm/handles.h" 12 #include "vm/handles.h"
14 #include "vm/heap.h" 13 #include "vm/heap.h"
15 #include "vm/isolate.h" 14 #include "vm/isolate.h"
16 #include "vm/object.h" 15 #include "vm/object.h"
17 #include "vm/object_store.h" 16 #include "vm/object_store.h"
18 #include "vm/object_id_ring.h" 17 #include "vm/object_id_ring.h"
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 StackZone zone(vm_isolate_); 116 StackZone zone(vm_isolate_);
118 HandleScope handle_scope(vm_isolate_); 117 HandleScope handle_scope(vm_isolate_);
119 Heap::Init(vm_isolate_); 118 Heap::Init(vm_isolate_);
120 ObjectStore::Init(vm_isolate_); 119 ObjectStore::Init(vm_isolate_);
121 Object::InitOnce(); 120 Object::InitOnce();
122 ArgumentsDescriptor::InitOnce(); 121 ArgumentsDescriptor::InitOnce();
123 StubCode::InitOnce(); 122 StubCode::InitOnce();
124 Symbols::InitOnce(vm_isolate_); 123 Symbols::InitOnce(vm_isolate_);
125 Scanner::InitOnce(); 124 Scanner::InitOnce();
126 Object::CreateInternalMetaData(); 125 Object::CreateInternalMetaData();
127 TargetCPUFeatures::InitOnce(); 126 CPUFeatures::InitOnce();
128 #if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64) 127 #if defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64)
129 // Dart VM requires at least SSE2. 128 // Dart VM requires at least SSE2.
130 if (!TargetCPUFeatures::sse2_supported()) { 129 if (!CPUFeatures::sse2_supported()) {
131 return "SSE2 is required."; 130 return "SSE2 is required.";
132 } 131 }
133 #endif 132 #endif
134 PremarkingVisitor premarker(vm_isolate_); 133 PremarkingVisitor premarker(vm_isolate_);
135 vm_isolate_->heap()->WriteProtect(false); 134 vm_isolate_->heap()->WriteProtect(false);
136 vm_isolate_->heap()->IterateOldObjects(&premarker); 135 vm_isolate_->heap()->IterateOldObjects(&premarker);
137 vm_isolate_->heap()->WriteProtect(true); 136 vm_isolate_->heap()->WriteProtect(true);
138 } 137 }
139 // There is a planned and known asymmetry here: We enter one scope for the VM 138 // There is a planned and known asymmetry here: We enter one scope for the VM
140 // isolate so that we can allocate the "persistent" scoped handles for the 139 // isolate so that we can allocate the "persistent" scoped handles for the
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 return predefined_handles_->handles_.AllocateScopedHandle(); 272 return predefined_handles_->handles_.AllocateScopedHandle();
274 } 273 }
275 274
276 275
277 bool Dart::IsReadOnlyHandle(uword address) { 276 bool Dart::IsReadOnlyHandle(uword address) {
278 ASSERT(predefined_handles_ != NULL); 277 ASSERT(predefined_handles_ != NULL);
279 return predefined_handles_->handles_.IsValidScopedHandle(address); 278 return predefined_handles_->handles_.IsValidScopedHandle(address);
280 } 279 }
281 280
282 } // namespace dart 281 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/cpuinfo_win.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698