Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1426563003: Permissions API: move multiple request to requestAll(). (Closed)

Created:
5 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 1 month ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Permissions API: move multiple request to requestAll(). Instead of overloading navigator.permissions.request(), .requestAll() is a clearer name and will not confuse the authors with two different return types. BUG=516626 Committed: https://crrev.com/e9b0b79b5b64ecd6df10152479c7266f24418d82 Cr-Commit-Position: refs/heads/master@{#356083}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : really rebase #

Patch Set 4 : fix tests #

Messages

Total messages: 10 (3 generated)
mlamouri (slow - plz ping)
Jochen, PTAL.
5 years, 1 month ago (2015-10-26 14:14:16 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-10-26 15:26:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426563003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426563003/60001
5 years, 1 month ago (2015-10-26 16:54:27 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-10-26 18:47:37 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e9b0b79b5b64ecd6df10152479c7266f24418d82 Cr-Commit-Position: refs/heads/master@{#356083}
5 years, 1 month ago (2015-10-26 18:48:21 UTC) #7
ortuno
you forgot to run the update_use_counter_feature_enum.py script to update histograms.xml
5 years, 1 month ago (2015-10-28 19:14:07 UTC) #9
mlamouri (slow - plz ping)
5 years, 1 month ago (2015-10-30 01:12:59 UTC) #10
Message was sent while issue was closed.
On 2015/10/28 at 19:14:07, ortuno wrote:
> you forgot to run the update_use_counter_feature_enum.py script to update
histograms.xml

Sorry about that and thanks for the ping. I see that someone did the update
afterwards so no action to be taken here.

Powered by Google App Engine
This is Rietveld 408576698