Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: third_party/WebKit/Source/modules/permissions/Permissions.cpp

Issue 1426563003: Permissions API: move multiple request to requestAll(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/permissions/Permissions.h" 6 #include "modules/permissions/Permissions.h"
7 7
8 #include "bindings/core/v8/Dictionary.h" 8 #include "bindings/core/v8/Dictionary.h"
9 #include "bindings/core/v8/Nullable.h" 9 #include "bindings/core/v8/Nullable.h"
10 #include "bindings/core/v8/ScriptPromise.h" 10 #include "bindings/core/v8/ScriptPromise.h"
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 if (exceptionState.hadException()) 134 if (exceptionState.hadException())
135 return exceptionState.reject(scriptState); 135 return exceptionState.reject(scriptState);
136 136
137 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ; 137 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
138 ScriptPromise promise = resolver->promise(); 138 ScriptPromise promise = resolver->promise();
139 139
140 client->requestPermission(type.get(), KURL(KURL(), scriptState->executionCon text()->securityOrigin()->toString()), new PermissionCallback(resolver, type.get ())); 140 client->requestPermission(type.get(), KURL(KURL(), scriptState->executionCon text()->securityOrigin()->toString()), new PermissionCallback(resolver, type.get ()));
141 return promise; 141 return promise;
142 } 142 }
143 143
144 ScriptPromise Permissions::request(ScriptState* scriptState, const Vector<Dictio nary>& rawPermissions) 144 ScriptPromise Permissions::revoke(ScriptState* scriptState, const Dictionary& ra wPermission)
145 { 145 {
146 WebPermissionClient* client = getClient(scriptState->executionContext()); 146 WebPermissionClient* client = getClient(scriptState->executionContext());
147 if (!client) 147 if (!client)
148 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(InvalidStateError, "In its current state, the global scope can't revoke p ermissions."));
149
150 ExceptionState exceptionState(ExceptionState::GetterContext, "revoke", "Per missions", scriptState->context()->Global(), scriptState->isolate());
151 Nullable<WebPermissionType> type = parsePermission(scriptState, rawPermissio n, exceptionState);
152 if (exceptionState.hadException())
153 return exceptionState.reject(scriptState);
154
155 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
156 ScriptPromise promise = resolver->promise();
157
158 client->revokePermission(type.get(), KURL(KURL(), scriptState->executionCont ext()->securityOrigin()->toString()), new PermissionCallback(resolver, type.get( )));
159 return promise;
160 }
161
162 ScriptPromise Permissions::requestAll(ScriptState* scriptState, const Vector<Dic tionary>& rawPermissions)
163 {
164 WebPermissionClient* client = getClient(scriptState->executionContext());
165 if (!client)
148 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(InvalidStateError, "In its current state, the global scope can't request permissions.")); 166 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(InvalidStateError, "In its current state, the global scope can't request permissions."));
149 167
150 ExceptionState exceptionState(ExceptionState::GetterContext, "request", "Pe rmissions", scriptState->context()->Global(), scriptState->isolate()); 168 ExceptionState exceptionState(ExceptionState::GetterContext, "request", "Pe rmissions", scriptState->context()->Global(), scriptState->isolate());
151 OwnPtr<Vector<WebPermissionType>> internalPermissions = adoptPtr(new Vector< WebPermissionType>()); 169 OwnPtr<Vector<WebPermissionType>> internalPermissions = adoptPtr(new Vector< WebPermissionType>());
152 OwnPtr<Vector<int>> callerIndexToInternalIndex = adoptPtr(new Vector<int>(ra wPermissions.size())); 170 OwnPtr<Vector<int>> callerIndexToInternalIndex = adoptPtr(new Vector<int>(ra wPermissions.size()));
153 for (size_t i = 0; i < rawPermissions.size(); ++i) { 171 for (size_t i = 0; i < rawPermissions.size(); ++i) {
154 const Dictionary& rawPermission = rawPermissions[i]; 172 const Dictionary& rawPermission = rawPermissions[i];
155 173
156 Nullable<WebPermissionType> type = parsePermission(scriptState, rawPermi ssion, exceptionState); 174 Nullable<WebPermissionType> type = parsePermission(scriptState, rawPermi ssion, exceptionState);
157 if (exceptionState.hadException()) 175 if (exceptionState.hadException())
(...skipping 14 matching lines...) Expand all
172 190
173 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ; 191 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
174 ScriptPromise promise = resolver->promise(); 192 ScriptPromise promise = resolver->promise();
175 193
176 WebVector<WebPermissionType> internalWebPermissions = *internalPermissions; 194 WebVector<WebPermissionType> internalWebPermissions = *internalPermissions;
177 client->requestPermissions(internalWebPermissions, KURL(KURL(), scriptState- >executionContext()->securityOrigin()->toString()), 195 client->requestPermissions(internalWebPermissions, KURL(KURL(), scriptState- >executionContext()->securityOrigin()->toString()),
178 new PermissionsCallback(resolver, internalPermissions.release(), callerI ndexToInternalIndex.release())); 196 new PermissionsCallback(resolver, internalPermissions.release(), callerI ndexToInternalIndex.release()));
179 return promise; 197 return promise;
180 } 198 }
181 199
182 ScriptPromise Permissions::revoke(ScriptState* scriptState, const Dictionary& ra wPermission)
183 {
184 WebPermissionClient* client = getClient(scriptState->executionContext());
185 if (!client)
186 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(InvalidStateError, "In its current state, the global scope can't revoke p ermissions."));
187
188 ExceptionState exceptionState(ExceptionState::GetterContext, "revoke", "Per missions", scriptState->context()->Global(), scriptState->isolate());
189 Nullable<WebPermissionType> type = parsePermission(scriptState, rawPermissio n, exceptionState);
190 if (exceptionState.hadException())
191 return exceptionState.reject(scriptState);
192
193 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
194 ScriptPromise promise = resolver->promise();
195
196 client->revokePermission(type.get(), KURL(KURL(), scriptState->executionCont ext()->securityOrigin()->toString()), new PermissionCallback(resolver, type.get( )));
197 return promise;
198 }
199
200 } // namespace blink 200 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698