Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1426513006: Background compilation fixes (Closed)

Created:
5 years, 1 month ago by srdjan
Modified:
5 years, 1 month ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 1 month ago (2015-11-05 00:15:27 UTC) #2
hausner
LGTM w/comment https://codereview.chromium.org/1426513006/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1426513006/diff/20001/runtime/vm/object.cc#newcode13573 runtime/vm/object.cc:13573: return String::Concat(Symbols::AllocationStubFor(), cls_name); Is this string concatenation ...
5 years, 1 month ago (2015-11-05 03:14:43 UTC) #3
srdjan
https://codereview.chromium.org/1426513006/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1426513006/diff/20001/runtime/vm/object.cc#newcode13573 runtime/vm/object.cc:13573: return String::Concat(Symbols::AllocationStubFor(), cls_name); On 2015/11/05 03:14:43, hausner wrote: > ...
5 years, 1 month ago (2015-11-05 16:53:48 UTC) #4
srdjan
5 years, 1 month ago (2015-11-05 17:53:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9dcd1fd076753acbbaa6dc4ad5433708598a4abd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698