Background compilation fixes

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 13538 matching lines @@
   Zone* zone = Thread::Current()->zone();
   if (IsStubCode()) {
     const char* name = StubCode::NameOfStub(EntryPoint());
     return zone->PrintToString("[stub: %s]", name);
   } else {
     return zone->PrintToString("Code entry:%" Px, EntryPoint());
   }
 }
 
 
+// Called by disassembler.
 RawString* Code::Name() const {
   const Object& obj = Object::Handle(owner());
   if (obj.IsNull()) {
     // Regular stub.
     const char* name = StubCode::NameOfStub(EntryPoint());
     ASSERT(name != NULL);
-    const String& stub_name = String::Handle(String::New(name));
-    return String::Concat(Symbols::StubPrefix(), stub_name);
+    const String& stub_name = String::Handle(Symbols::New(name));
+    return Symbols::FromConcat(Symbols::StubPrefix(), stub_name);
   } else if (obj.IsClass()) {
     // Allocation stub.
     const Class& cls = Class::Cast(obj);
     String& cls_name = String::Handle(cls.Name());
     ASSERT(!cls_name.IsNull());
     return String::Concat(Symbols::AllocationStubFor(), cls_name);

[hausner, 2015/11/05 03:14:43]

Is this string concatenation not a problem?

[srdjan, 2015/11/05 16:53:47]

Done.

   } else {
     ASSERT(obj.IsFunction());
     // Dart function.
     return Function::Cast(obj).name();
   }
 }
 
 
 RawString* Code::PrettyName() const {
   const Object& obj = Object::Handle(owner());
@@ skipping 8363 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart