Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1426433002: ios: Use a 10.7 deployment target for host builds. (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

iOS: Use a 10.7 deployment target for host builds. The internal iOS build used to use libstdc++, but after https://codereview.chromium.org/1334273004/ force libc+++ on for iOS the internal bots broke because they use Xcode's clang and Xcode's clang complains if -stdlib=libc++ is passed and the deployment target is not at least 10.7. As a fix, set the mac deployment target for iOS host compiles to 10.7, and suppress warnings about deprecated functions for iOS host compiles. (The warnings can't be fixed until the deployment target is increased on Mac too; this is covered by crbug.com/547071) BUG=535104, 400091 Committed: https://crrev.com/469f0e325c36f278a9849051265f65cc2dcf804a Cr-Commit-Position: refs/heads/master@{#355822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M build/common.gypi View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Nico
This is the last piece of the puzzle.
5 years, 1 month ago (2015-10-23 16:13:35 UTC) #3
sdefresne
lgtm
5 years, 1 month ago (2015-10-23 16:15:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426433002/1
5 years, 1 month ago (2015-10-23 16:16:56 UTC) #6
Mark Mentovai
LGTM
5 years, 1 month ago (2015-10-23 16:41:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-23 17:59:23 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/469f0e325c36f278a9849051265f65cc2dcf804a Cr-Commit-Position: refs/heads/master@{#355822}
5 years, 1 month ago (2015-10-23 18:00:53 UTC) #9
Nico
5 years, 1 month ago (2015-10-27 18:25:20 UTC) #10
Message was sent while issue was closed.
I filed http://crbug.com/548286 for porting this to gn (i tried to just do that,
but the gn/ios build is busted without any local changes, so i couldn't test my
patch, so i pasted it into a bug instead)

Powered by Google App Engine
This is Rietveld 408576698