Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: build/common.gypi

Issue 1426433002: ios: Use a 10.7 deployment target for host builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index e7dc6170c65224e50ad30471968433c0cf10f690..87d0eb3bc82e22a3e85219b3af5fdad35526a285 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1928,13 +1928,17 @@
'conditions': [
['OS=="ios"', {
'mac_sdk_min%': '10.8',
+ # The iOS build can use Xcode's clang, and that will complain
+ # about -stdlib=libc++ if the deployment target is not at least
+ # 10.7.
+ 'mac_deployment_target%': '10.7',
}, { # else OS!="ios"
'mac_sdk_min%': '10.10',
+ 'mac_deployment_target%': '10.6',
}],
],
'mac_sdk_path%': '',
- 'mac_deployment_target%': '10.6',
},
'mac_sdk_min': '<(mac_sdk_min)',
@@ -5448,6 +5452,17 @@
'ARCHS': [
'x86_64',
],
+ 'WARNING_CFLAGS': [
+ # TODO(thakis): Remove this once the deployment target on OS X
+ # is 10.7 too, http://crbug.com/547071
+ # In general, it is NOT OK to add -Wno-deprecated-declarations
+ # anywhere, you should instead fix your code instead. But host
+ # compiles on iOS are really mac compiles, so this will be fixed
+ # when the mac deployment target is increased. (Some of the
+ # fixes depend on OS X 10.7 so they can't be done before mac
+ # upgrades).
+ '-Wno-deprecated-declarations',
+ ],
},
}],
['_toolset=="target"', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698