Revert 193777 "url: Changes to make it build standalone."

Revert 193777 "url: Changes to make it build standalone."

url/url_canon_stdstring.h:65: error: undefined reference to 'vtable for url_canon::StdStringCanonOutput'


> url: Changes to make it build standalone.
> 
> - Update the gyp file.
> - Rename the gyp file from googleurl.gyp to url.gyp, so it matches the directory
> name.
> - Update the header include paths.
> - Update the header include guards.
> - Rename the target name from googleurl to url and googleurl_unittests to
> url_unittests.
> - Add missing OVERRIDEs where clang complains.
> 
> BUG=229660
> TEST=url_unittests
> R=brettw@chromium.org
> 
> Review URL: https://codereview.chromium.org/14016005

TBR=tfarina@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194155

[jochen (gone - plz use gerrit), 2013-04-15 09:30:48]

Committed patchset #1 manually as r194155.

[tfarina, 2013-04-15 09:49:09]

Can you revert this revert and the blink one you reverted?

Which bot in the waterfall was presenting this error?

I don't see this locally (Linux) and i have ran
url_unittests/googleurl_unittests thousands of times.

Thanks!

[jochen (gone - plz use gerrit), 2013-04-15 09:50:47]

all XP bots are fail to run a single executable. Apparently, they can't load
URL.DLL.

[tfarina, 2013-04-15 09:56:04]

On Monday, April 15, 2013, wrote:

> all XP bots are fail to run a single executable. Apparently, they can't
> load
> URL.DLL.

But you are reverting a change that is isolated and it shouln't be
affecting anyone.

I think you wanted to revert the DEPs roll?

Because in this change no bots should be linking to url.dll/url.dll. But
with googleurl.dll since there is no calls to url/url.gyp:url


>
https://codereview.chromium.**org/14264002/<https://codereview.chromium.org/1...
>


-- 
Thiago

[jochen (gone - plz use gerrit), 2013-04-15 09:57:58]

On 2013/04/15 09:56:04, tfarina wrote:
> On Monday, April 15, 2013, wrote:
> 
> > all XP bots are fail to run a single executable. Apparently, they can't
> > load
> > URL.DLL.
> 
> But you are reverting a change that is isolated and it shouln't be
> affecting anyone.
> 
> I think you wanted to revert the DEPs roll?

I already reverted that one.

> 
> Because in this change no bots should be linking to url.dll/url.dll. But
> with googleurl.dll since there is no calls to url/url.gyp:url
>

it's still called from blink. So I also reverted the blink CL.

As soon as the tree is green again, I'll look into re-reverting this change
again, ok?
 
> 
> >
>
https://codereview.chromium.**org/14264002/%3Chttps://codereview.chromium.org...>
> >
> 
> 
> -- 
> Thiago

[tfarina, 2013-04-15 10:05:52]

On Mon, Apr 15, 2013 at 6:57 AM, <jochen@chromium.org> wrote:

> On 2013/04/15 09:56:04, tfarina wrote:
>
>> On Monday, April 15, 2013, wrote:
>>
>
>  > all XP bots are fail to run a single executable. Apparently, they can't
>> > load
>> > URL.DLL.
>>
>
>  But you are reverting a change that is isolated and it shouln't be
>> affecting anyone.
>>
>
>  I think you wanted to revert the DEPs roll?
>>
>
> I already reverted that one.
>
> Ouch! :(

I don't see that on my Inbox yet.


>
>
>  Because in this change no bots should be linking to url.dll/url.dll. But
>> with googleurl.dll since there is no calls to url/url.gyp:url
>>
>
>
> it's still called from blink. So I also reverted the blink CL.
>
> As soon as the tree is green again, I'll look into re-reverting this change
> again, ok?
>
OK, Thanks!

-- 
Thiago