Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 14016005: url: Changes to make it build standalone. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

url: Changes to make it build standalone. - Update the gyp file. - Rename the gyp file from googleurl.gyp to url.gyp, so it matches the directory name. - Update the header include paths. - Update the header include guards. - Rename the target name from googleurl to url and googleurl_unittests to url_unittests. - Add missing OVERRIDEs where clang complains. BUG=229660 TEST=url_unittests R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193777

Patch Set 1 #

Total comments: 2

Patch Set 2 : add blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -254 lines) Patch
D url/googleurl.gyp View 1 chunk +0 lines, -109 lines 0 comments Download
M url/gurl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M url/gurl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M url/gurl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A url/url.gyp View 1 chunk +109 lines, -0 lines 0 comments Download
M url/url_canon.h View 2 chunks +7 lines, -6 lines 0 comments Download
M url/url_canon_etc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_filesystemurl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M url/url_canon_fileurl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M url/url_canon_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_icu.h View 3 chunks +6 lines, -5 lines 0 comments Download
M url/url_canon_icu.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M url/url_canon_internal.h View 2 chunks +4 lines, -4 lines 0 comments Download
M url/url_canon_internal.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M url/url_canon_internal_file.h View 2 chunks +5 lines, -5 lines 0 comments Download
M url/url_canon_ip.h View 2 chunks +6 lines, -6 lines 0 comments Download
M url/url_canon_ip.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_mailtourl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M url/url_canon_path.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M url/url_canon_pathurl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_query.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_relative.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M url/url_canon_stdstring.h View 4 chunks +9 lines, -11 lines 0 comments Download
A url/url_canon_stdstring.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M url/url_canon_stdurl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/url_canon_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M url/url_common.h View 2 chunks +3 lines, -4 lines 0 comments Download
M url/url_file.h View 2 chunks +4 lines, -4 lines 0 comments Download
M url/url_parse.h View 2 chunks +4 lines, -4 lines 0 comments Download
M url/url_parse.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M url/url_parse_file.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M url/url_parse_internal.h View 2 chunks +4 lines, -4 lines 0 comments Download
M url/url_parse_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/url_test_utils.h View 2 chunks +4 lines, -4 lines 0 comments Download
M url/url_util.h View 2 chunks +6 lines, -6 lines 0 comments Download
M url/url_util.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M url/url_util_internal.h View 2 chunks +5 lines, -5 lines 0 comments Download
M url/url_util_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Hi Brett, could you review this to me? Thanks,
7 years, 8 months ago (2013-04-11 03:20:34 UTC) #1
brettw
lgtm https://codereview.chromium.org/14016005/diff/1/url/url_canon_internal.cc File url/url_canon_internal.cc (right): https://codereview.chromium.org/14016005/diff/1/url/url_canon_internal.cc#newcode32 url/url_canon_internal.cc:32: #include <cstdio> I think there should be a ...
7 years, 8 months ago (2013-04-11 18:15:24 UTC) #2
tfarina
https://codereview.chromium.org/14016005/diff/1/url/url_canon_internal.cc File url/url_canon_internal.cc (right): https://codereview.chromium.org/14016005/diff/1/url/url_canon_internal.cc#newcode32 url/url_canon_internal.cc:32: #include <cstdio> On 2013/04/11 18:15:24, brettw wrote: > I ...
7 years, 8 months ago (2013-04-11 22:11:48 UTC) #3
tfarina
7 years, 8 months ago (2013-04-11 22:12:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r193777 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698