Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Issue 1426343002: EDK: Move mutex.*, cond_var.*, and thread_annotations.h to //mojo/edk/util. (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Move mutex.*, cond_var.*, and thread_annotations.h to //mojo/edk/util. (Also, make them not depend on //base/logging.h. Add some simple logging macros for those needs.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d42e48a950f4c69b976b67036307db9790a684e7

Patch Set 1 #

Total comments: 3

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -1080 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/embedder/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 6 chunks +0 lines, -8 lines 0 comments Download
M mojo/edk/system/channel.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/channel.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/channel_endpoint.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/channel_endpoint.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/channel_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/channel_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
D mojo/edk/system/cond_var.h View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/edk/system/cond_var.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D mojo/edk/system/cond_var_unittest.cc View 1 chunk +0 lines, -170 lines 0 comments Download
M mojo/edk/system/connection_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/core.h View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/system/core.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/core_test_base.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/endpoint_relayer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/endpoint_relayer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/incoming_endpoint.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/incoming_endpoint.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/master_connection_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/master_connection_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
D mojo/edk/system/mutex.h View 1 chunk +0 lines, -84 lines 0 comments Download
D mojo/edk/system/mutex.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/edk/system/mutex_unittest.cc View 1 chunk +0 lines, -201 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/raw_channel.h View 3 chunks +6 lines, -4 lines 0 comments Download
M mojo/edk/system/raw_channel.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/raw_channel_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/simple_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/simple_dispatcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/slave_connection_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/slave_connection_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
D mojo/edk/system/thread_annotations.h View 1 chunk +0 lines, -85 lines 0 comments Download
D mojo/edk/system/thread_annotations_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M mojo/edk/system/waitable_event.h View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/system/waitable_event.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/waiter.h View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/waiter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/waiter_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/test/multiprocess_test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/util/BUILD.gn View 2 chunks +14 lines, -2 lines 0 comments Download
A + mojo/edk/util/cond_var.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + mojo/edk/util/cond_var.cc View 1 8 chunks +25 lines, -25 lines 0 comments Download
A + mojo/edk/util/cond_var_unittest.cc View 8 chunks +14 lines, -11 lines 0 comments Download
A mojo/edk/util/logging_internal.h View 1 chunk +61 lines, -0 lines 0 comments Download
A mojo/edk/util/logging_internal.cc View 1 chunk +33 lines, -0 lines 0 comments Download
A + mojo/edk/util/mutex.h View 2 chunks +8 lines, -9 lines 0 comments Download
A + mojo/edk/util/mutex.cc View 1 chunk +14 lines, -15 lines 0 comments Download
A + mojo/edk/util/mutex_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
A + mojo/edk/util/thread_annotations.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/edk/util/thread_annotations_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 1 month ago (2015-11-03 21:56:13 UTC) #1
jamesr
lgtm w/ one typo https://codereview.chromium.org/1426343002/diff/1/mojo/edk/util/cond_var.cc File mojo/edk/util/cond_var.cc (right): https://codereview.chromium.org/1426343002/diff/1/mojo/edk/util/cond_var.cc#newcode93 mojo/edk/util/cond_var.cc:93: INTERNAL_DCHECK_WITH_ERRNO(!error, pthread_cond_init, error); you probably ...
5 years, 1 month ago (2015-11-03 22:34:49 UTC) #2
viettrungluu
5 years, 1 month ago (2015-11-03 22:54:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d42e48a950f4c69b976b67036307db9790a684e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698