[Android] Refactor md5_check + add tests

[Android] Refactor md5_check + add tests

This adds a function md5_check.CallAndRecordIfStale that makes the
common (and currently only) use of Md5Checker much simpler (i.e just
call this function). All the users of md5_check are updated to use this
function, and everything else in md5_check is no longer part of the
public API.

Also, adds tests for the md5_check module. These are only run manually currently.

BUG=158821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194377

[nilesh, 2013-04-15 18:28:42]

LGTM with nits

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/apk_install.py
File build/android/gyp/apk_install.py (right):

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/apk_install...
build/android/gyp/apk_install.py:41: record_path = '%s.%s.md5' %
(options.apk_path, serial_number)
%s.%s.md5.stamp

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/create_devi...
File build/android/gyp/create_device_library_links.py (right):

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/create_devi...
build/android/gyp/create_device_library_links.py:55: record_path =
'%s.%s.link.md5' % (host_path, serial_number)
.stamp

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/dex.py
File build/android/gyp/dex.py (right):

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/dex.py#newc...
build/android/gyp/dex.py:20: record_path = '%s.md5' % options.dex_path
.stamp

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/util/md5_ch...
File build/android/gyp/util/md5_check.py (right):

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/util/md5_ch...
build/android/gyp/util/md5_check.py:17: md5_checker = _Md5Checker(
extra space before Md5Checker

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/util/md5_ch...
build/android/gyp/util/md5_check.py:53: # them.
I think we should assert here instead of modifying the record_path

[cjhopman, 2013-04-15 18:32:35]

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/apk_install.py
File build/android/gyp/apk_install.py (right):

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/apk_install...
build/android/gyp/apk_install.py:41: record_path = '%s.%s.md5' %
(options.apk_path, serial_number)
On 2013/04/15 18:28:42, nilesh wrote:
> %s.%s.md5.stamp

Done.

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/create_devi...
File build/android/gyp/create_device_library_links.py (right):

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/create_devi...
build/android/gyp/create_device_library_links.py:55: record_path =
'%s.%s.link.md5' % (host_path, serial_number)
On 2013/04/15 18:28:42, nilesh wrote:
> .stamp

Done.

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/dex.py
File build/android/gyp/dex.py (right):

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/dex.py#newc...
build/android/gyp/dex.py:20: record_path = '%s.md5' % options.dex_path
On 2013/04/15 18:28:42, nilesh wrote:
> .stamp

Done.

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/util/md5_ch...
File build/android/gyp/util/md5_check.py (right):

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/util/md5_ch...
build/android/gyp/util/md5_check.py:17: md5_checker = _Md5Checker(
On 2013/04/15 18:28:42, nilesh wrote:
> extra space before Md5Checker
>  

Done.

https://codereview.chromium.org/14263006/diff/1/build/android/gyp/util/md5_ch...
build/android/gyp/util/md5_check.py:53: # them.
On 2013/04/15 18:28:42, nilesh wrote:
> I think we should assert here instead of modifying the record_path

Done.

[cjhopman, 2013-04-16 17:06:39]

Committed patchset #3 manually as r194377 (presubmit successful).