Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2114)

Unified Diff: build/android/gyp/create_device_library_links.py

Issue 14263006: [Android] Refactor md5_check + add tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@java_toc
Patch Set: Rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/apk_install.py ('k') | build/android/gyp/dex.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/create_device_library_links.py
diff --git a/build/android/gyp/create_device_library_links.py b/build/android/gyp/create_device_library_links.py
index e71f72729cb90bf2eee3498bb27c2b79c170756a..48aa61eea997302ee2efa8ee0a5f41dfe14219f7 100755
--- a/build/android/gyp/create_device_library_links.py
+++ b/build/android/gyp/create_device_library_links.py
@@ -47,14 +47,16 @@ def CreateLinks(options):
serial_number = adb.Adb().GetSerialNumber()
for lib in libraries:
host_path = os.path.join(options.libraries_dir, lib)
-
- md5_stamp = '%s.%s.link.md5' % (host_path, serial_number)
- md5_checker = md5_check.Md5Checker(stamp=md5_stamp, inputs=[host_path])
- if md5_checker.IsStale():
+ def CreateLink():
link = '/data/data/' + apk_package + '/lib/' + lib
target = options.target_dir + '/' + lib
RunLinkCommand(adb, target, link)
- md5_checker.Write()
+
+ record_path = '%s.%s.link.md5.stamp' % (host_path, serial_number)
+ md5_check.CallAndRecordIfStale(
+ CreateLink,
+ record_path=record_path,
+ input_paths=[host_path])
def main(argv):
« no previous file with comments | « build/android/gyp/apk_install.py ('k') | build/android/gyp/dex.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698