Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1426293003: For now, don't assume failed-access-check callback to throw. (Closed)

Created:
5 years, 1 month ago by neis
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

For now, don't assume failed-access-check callback to throw. R=verwaest@chromium.org BUG=chromium:548194 LOG=y Committed: https://crrev.com/f66c3f5c356583e0f8e1bab7e6ff1eed86d2d1aa Cr-Commit-Position: refs/heads/master@{#31745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/objects.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
neis
5 years, 1 month ago (2015-11-03 11:49:12 UTC) #1
Toon Verwaest
lgtm, although if possible I'd prefer the old Throw without UNREACHABLE as a temporary path ...
5 years, 1 month ago (2015-11-03 12:07:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426293003/1
5 years, 1 month ago (2015-11-03 13:14:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 13:32:42 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 13:33:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f66c3f5c356583e0f8e1bab7e6ff1eed86d2d1aa
Cr-Commit-Position: refs/heads/master@{#31745}

Powered by Google App Engine
This is Rietveld 408576698