src/objects.cc - Issue 1426293003: For now, don't assume failed-access-check callback to throw.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1426293003: For now, don't assume failed-access-check callback to throw. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 7422aec4e6603ddbbf52a3295a9fea13e8da9b6b..a249d9890f3975bce4a63641071667c1ed566105 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -1071,10 +1071,7 @@ Maybe<bool> JSObject::SetPropertyWithFailedAccessCheck(

it->isolate()->ReportFailedAccessCheck(checked);

RETURN_VALUE_IF_SCHEDULED_EXCEPTION(it->isolate(), Nothing<bool>());

- UNREACHABLE();

- it->isolate()->Throw(

- *it->isolate()->factory()->NewTypeError(MessageTemplate::kNoAccess));

- return Nothing<bool>();

+ return Just(true);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »