Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14262009: Add support for multi-line GlobalError messages to Views. (Closed)

Created:
7 years, 8 months ago by Yoyo Zhou
Modified:
7 years, 8 months ago
Reviewers:
sail, sky
CC:
chromium-reviews, akalin, Raghu Simha, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org, haitaol1, tim (not reviewing)
Visibility:
Public.

Description

Add support for multi-line GlobalError messages to Views. (TODO for GTK and Cocoa.) Screenshot: http://i.imgur.com/u2EbEr6.png BUG=229083 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194411

Patch Set 1 #

Total comments: 3

Patch Set 2 : only Messages #

Patch Set 3 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -49 lines) Patch
M chrome/browser/extensions/extension_disabled_ui.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_error_ui.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_error_ui.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_error_ui_default.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_error_ui_default.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_warning_badge_service.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/external_install_ui.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_global_error.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_global_error.cc View 1 2 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/signin/signin_global_error_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_global_error.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_global_error.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.mm View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/global_error/global_error.h View 1 2 chunks +6 lines, -2 lines 3 comments Download
M chrome/browser/ui/global_error/global_error_service_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/global_error/global_error_service_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/global_error_bubble.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/global_error_bubble_view.cc View 1 4 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yoyo Zhou
7 years, 8 months ago (2013-04-15 18:17:00 UTC) #1
sail
Looks great! https://chromiumcodereview.appspot.com/14262009/diff/1/chrome/browser/ui/global_error/global_error.h File chrome/browser/ui/global_error/global_error.h (right): https://chromiumcodereview.appspot.com/14262009/diff/1/chrome/browser/ui/global_error/global_error.h#newcode58 chrome/browser/ui/global_error/global_error.h:58: virtual string16 GetBubbleViewMessage() = 0; Could you ...
7 years, 8 months ago (2013-04-15 18:19:37 UTC) #2
Yoyo Zhou
https://chromiumcodereview.appspot.com/14262009/diff/1/chrome/browser/ui/global_error/global_error.h File chrome/browser/ui/global_error/global_error.h (right): https://chromiumcodereview.appspot.com/14262009/diff/1/chrome/browser/ui/global_error/global_error.h#newcode58 chrome/browser/ui/global_error/global_error.h:58: virtual string16 GetBubbleViewMessage() = 0; On 2013/04/15 18:19:38, sail ...
7 years, 8 months ago (2013-04-15 18:43:28 UTC) #3
sail
https://chromiumcodereview.appspot.com/14262009/diff/1/chrome/browser/ui/global_error/global_error.h File chrome/browser/ui/global_error/global_error.h (right): https://chromiumcodereview.appspot.com/14262009/diff/1/chrome/browser/ui/global_error/global_error.h#newcode58 chrome/browser/ui/global_error/global_error.h:58: virtual string16 GetBubbleViewMessage() = 0; On 2013/04/15 18:43:28, Yoyo ...
7 years, 8 months ago (2013-04-15 19:04:41 UTC) #4
Yoyo Zhou
Made changes and added TODOs.
7 years, 8 months ago (2013-04-15 22:35:31 UTC) #5
sail
LGTM! https://codereview.chromium.org/14262009/diff/13002/chrome/browser/ui/global_error/global_error.h File chrome/browser/ui/global_error/global_error.h (right): https://codereview.chromium.org/14262009/diff/13002/chrome/browser/ui/global_error/global_error.h#newcode59 chrome/browser/ui/global_error/global_error.h:59: // TODO(yoz): Add multi-line support for GTK and ...
7 years, 8 months ago (2013-04-16 00:52:26 UTC) #6
Yoyo Zhou
https://codereview.chromium.org/14262009/diff/13002/chrome/browser/ui/global_error/global_error.h File chrome/browser/ui/global_error/global_error.h (right): https://codereview.chromium.org/14262009/diff/13002/chrome/browser/ui/global_error/global_error.h#newcode59 chrome/browser/ui/global_error/global_error.h:59: // TODO(yoz): Add multi-line support for GTK and Cocoa. ...
7 years, 8 months ago (2013-04-16 07:05:34 UTC) #7
sail
https://codereview.chromium.org/14262009/diff/13002/chrome/browser/ui/global_error/global_error.h File chrome/browser/ui/global_error/global_error.h (right): https://codereview.chromium.org/14262009/diff/13002/chrome/browser/ui/global_error/global_error.h#newcode59 chrome/browser/ui/global_error/global_error.h:59: // TODO(yoz): Add multi-line support for GTK and Cocoa. ...
7 years, 8 months ago (2013-04-16 16:27:32 UTC) #8
Yoyo Zhou
TBR=sky for OWNERS, simple refactoring.
7 years, 8 months ago (2013-04-16 19:09:53 UTC) #9
Yoyo Zhou
7 years, 8 months ago (2013-04-16 19:18:05 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 manually as r194411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698