Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2548)

Unified Diff: chrome/browser/ui/global_error/global_error.h

Issue 14262009: Add support for multi-line GlobalError messages to Views. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/global_error/global_error.h
diff --git a/chrome/browser/ui/global_error/global_error.h b/chrome/browser/ui/global_error/global_error.h
index 10bd5c2da81976d1556f01ffa33cb132b81f4f1c..3569c0e241f3620d95508f3c7ec34223b42eddda 100644
--- a/chrome/browser/ui/global_error/global_error.h
+++ b/chrome/browser/ui/global_error/global_error.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_UI_GLOBAL_ERROR_GLOBAL_ERROR_H_
#define CHROME_BROWSER_UI_GLOBAL_ERROR_GLOBAL_ERROR_H_
+#include <vector>
+
#include "base/basictypes.h"
#include "base/memory/weak_ptr.h"
#include "base/string16.h"
@@ -52,8 +54,10 @@ class GlobalError : public base::SupportsWeakPtr<GlobalError> {
virtual int GetBubbleViewIconResourceID();
// Returns the title for the bubble view.
virtual string16 GetBubbleViewTitle() = 0;
- // Returns the message for the bubble view.
- virtual string16 GetBubbleViewMessage() = 0;
+ // Returns the messages for the bubble view, one per line. Multiple messages
+ // are only supported on Views.
+ // TODO(yoz): Add multi-line support for GTK and Cocoa.
sail 2013/04/16 00:52:26 don't need this TODO since they're already present
Yoyo Zhou 2013/04/16 07:05:34 I figure it can't hurt to have it here too.
sail 2013/04/16 16:27:32 Sounds good.
+ virtual std::vector<string16> GetBubbleViewMessages() = 0;
// Returns the accept button label for the bubble view.
virtual string16 GetBubbleViewAcceptButtonLabel() = 0;
// Returns the cancel button label for the bubble view. To hide the cancel

Powered by Google App Engine
This is Rietveld 408576698