Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1366)

Issue 14262005: Fix bug introduced by r13960. (Closed)

Created:
7 years, 8 months ago by Vyacheslav Egorov (Google)
Modified:
7 years, 8 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix bug introduced by r13960. Allocator does not backtrack thus during allocation we must not create an unhandled live range which starts before the start of the current live range. If such range is added to the list of unhandled it might see an inconsistent state of active/inactive live-ranges as they are retired to handled as soon as start of the current live range is larger than their end. Add assertion to catch this kind of bugs early. TEST=NavierStokes does not fail on ARM Committed: http://code.google.com/p/v8/source/detail?r=14274

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Kill duplication betwee SpillBetweenUntil and SpillBetween #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M src/lithium-allocator.h View 2 chunks +12 lines, -1 line 1 comment Download
M src/lithium-allocator.cc View 1 2 5 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
Sven, Please take a look. This fixes NavierStokes on ARM. Creating regression test proves to ...
7 years, 8 months ago (2013-04-15 13:56:43 UTC) #1
Sven Panne
LGTM, at least I hope so after scribbling around on paper a bit... :-} https://codereview.chromium.org/14262005/diff/4001/src/lithium-allocator.h ...
7 years, 8 months ago (2013-04-16 06:52:12 UTC) #2
Vyacheslav Egorov (Google)
7 years, 8 months ago (2013-04-16 11:31:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r14274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698