mojo/runner/BUILD.gn - Issue 1425853003: mandoline: Fix ICU initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/runner/BUILD.gn

Issue 1425853003: mandoline: Fix ICU initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't initialize ICU again in the shell. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/runner/BUILD.gn

diff --git a/mojo/runner/BUILD.gn b/mojo/runner/BUILD.gn

index 6dd9642401a1c844eab46ae42627984e3551b4ed..11da20171dff1dfe6fd54b743875b9a44e02fb3d 100644

--- a/mojo/runner/BUILD.gn

+++ b/mojo/runner/BUILD.gn

@@ -51,7 +51,10 @@ source_set("mojo_runner_lib") {

"register_local_aliases.cc",

"register_local_aliases.h",

]

- deps += [ "//components/tracing:startup_tracing" ]

+ deps += [

+ "//components/tracing:startup_tracing",

+ "//third_party/icu:icudata",

+ ]

} else {

sources += [

"android/context_init.h",

@@ -104,6 +107,7 @@ source_set("init") {

deps = [

":switches",

"//base",

+ "//base:i18n",

]

}

@@ -164,6 +168,8 @@ source_set("lib") {

public_deps = [

":init",

":switches",

+ ":native_application_support",

+ "//mojo/shell",

]

data_deps = [