Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: base/i18n/icu_util.h

Issue 1425853003: mandoline: Fix ICU initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't initialize ICU again in the shell. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/i18n/icu_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/i18n/icu_util.h
diff --git a/base/i18n/icu_util.h b/base/i18n/icu_util.h
index d62f8bac0d946dbb09d71290f58c77b27e5ca63f..ff06b3dc8deb9bad06d930968872b171ef6c30a5 100644
--- a/base/i18n/icu_util.h
+++ b/base/i18n/icu_util.h
@@ -17,11 +17,19 @@ namespace i18n {
// function should be called before ICU is used.
BASE_I18N_EXPORT bool InitializeICU();
+// Returns a raw PlatformFile to the caller. Each call to this function returns
+// a new file descriptor. The caller is responsible for closing this file when
+// done with it.
+BASE_I18N_EXPORT PlatformFile OpenIcuDataFile();
jam 2015/11/05 19:29:03 nit: ICU for consistency with the rest of the file
+
#if ICU_UTIL_DATA_IMPL == ICU_UTIL_DATA_FILE
+#if defined(OS_ANDROID)
// Returns the PlatformFile and Region that was initialized by InitializeICU().
-// Use with InitializeICUWithFileDescriptor().
+// Use with InitializeICUWithFileDescriptor(). This handle can't be shared
+// within the same process.
BASE_I18N_EXPORT PlatformFile GetIcuDataFileHandle(
MemoryMappedFile::Region* out_region);
+#endif
// Android and html_viewer use a file descriptor passed by browser process to
// initialize ICU in render processes.
« no previous file with comments | « no previous file | base/i18n/icu_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698