components/resource_provider/public/cpp/resource_loader.h - Issue 1425853003: mandoline: Fix ICU initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/resource_provider/public/cpp/resource_loader.h

Issue 1425853003: mandoline: Fix ICU initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't initialize ICU again in the shell. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/resource_provider/public/cpp/resource_loader.h

diff --git a/components/resource_provider/public/cpp/resource_loader.h b/components/resource_provider/public/cpp/resource_loader.h

index 2b055aa3ba28275410a7ad8e68dfc8133fc71104..69b50948e640a61a5f2bb5faecb4adb253068412 100644

--- a/components/resource_provider/public/cpp/resource_loader.h

+++ b/components/resource_provider/public/cpp/resource_loader.h

@@ -46,8 +46,6 @@ class ResourceLoader {

// Releases and returns the file wrapping the handle.

base::File ReleaseFile(const std::string& path);

- base::File GetICUFile();

bool loaded() const { return loaded_; }

private:

@@ -56,7 +54,6 @@ class ResourceLoader {

// Callback when resources have loaded.

void OnGotResources(const std::vector<std::string>& paths,

mojo::Array<mojo::ScopedHandle> resources);

- void OnGotICU(base::File* file, mojo::ScopedHandle handle);

ResourceProviderPtr resource_provider_;