Chromium Code Reviews Chromium Code Reviews
Issue
14258007:
GTK: Display a native bubble (instead of the JS one) after the web signin flow. (Closed)
DescriptionGTK: Display a native bubble (instead of the JS one) after the web signin flow.
Part of a 3 CL Voltron, along with:
[Win] https://codereview.chromium.org/13979003/
[Mac] https://codereview.chromium.org/13845022/
(branched off https://codereview.chromium.org/13979003)
BUG=119728
TEST=Open Chrome. Delete all your profiles, so that you have a fresh one. Open a new tab, and press the "sign in" link in the top right corner. Sign in. Upon completion, this should show a native popup bubble, anchored off the wrench menu. If you try to log in with the same email in another profile, the bubble should display a sad error message. Check out the issue description for screenshots.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197770
Patch Set 1 #Patch Set 2 : Fix label alignment #Patch Set 3 : Fix bot errors #Patch Set 4 : Added error message #Patch Set 5 : Rebase #Patch Set 6 : Unbork patch set :| #Patch Set 7 : Still trying to unbork the rebase #Patch Set 8 : Ditto #Patch Set 9 : Fixed histogram logging #Patch Set 10 : Rebase with master #
Messages
Total messages: 4 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
