Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chrome/browser/ui/gtk/browser_window_gtk.cc

Issue 14258007: GTK: Display a native bubble (instead of the JS one) after the web signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntpBubble
Patch Set: Rebase with master Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/one_click_signin_bubble_gtk.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/browser_window_gtk.h" 5 #include "chrome/browser/ui/gtk/browser_window_gtk.h"
6 6
7 #include <gdk/gdkkeysyms.h> 7 #include <gdk/gdkkeysyms.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <string> 10 #include <string>
(...skipping 960 matching lines...) Expand 10 before | Expand all | Expand 10 after
971 void BrowserWindowGtk::ShowChromeToMobileBubble() { 971 void BrowserWindowGtk::ShowChromeToMobileBubble() {
972 toolbar_->GetLocationBarView()->ShowChromeToMobileBubble(); 972 toolbar_->GetLocationBarView()->ShowChromeToMobileBubble();
973 } 973 }
974 974
975 #if defined(ENABLE_ONE_CLICK_SIGNIN) 975 #if defined(ENABLE_ONE_CLICK_SIGNIN)
976 void BrowserWindowGtk::ShowOneClickSigninBubble( 976 void BrowserWindowGtk::ShowOneClickSigninBubble(
977 OneClickSigninBubbleType type, 977 OneClickSigninBubbleType type,
978 const string16& email, 978 const string16& email,
979 const string16& error_message, 979 const string16& error_message,
980 const StartSyncCallback& start_sync_callback) { 980 const StartSyncCallback& start_sync_callback) {
981 new OneClickSigninBubbleGtk(this, type, email, start_sync_callback); 981
982 new OneClickSigninBubbleGtk(this, type, email,
983 error_message, start_sync_callback);
982 } 984 }
983 #endif 985 #endif
984 986
985 bool BrowserWindowGtk::IsDownloadShelfVisible() const { 987 bool BrowserWindowGtk::IsDownloadShelfVisible() const {
986 return download_shelf_.get() && download_shelf_->IsShowing(); 988 return download_shelf_.get() && download_shelf_->IsShowing();
987 } 989 }
988 990
989 DownloadShelf* BrowserWindowGtk::GetDownloadShelf() { 991 DownloadShelf* BrowserWindowGtk::GetDownloadShelf() {
990 if (!download_shelf_.get()) 992 if (!download_shelf_.get())
991 download_shelf_.reset(new DownloadShelfGtk(browser_.get(), 993 download_shelf_.reset(new DownloadShelfGtk(browser_.get(),
(...skipping 1400 matching lines...) Expand 10 before | Expand all | Expand 10 after
2392 wm_type == ui::WM_OPENBOX || 2394 wm_type == ui::WM_OPENBOX ||
2393 wm_type == ui::WM_XFWM4); 2395 wm_type == ui::WM_XFWM4);
2394 } 2396 }
2395 2397
2396 // static 2398 // static
2397 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) { 2399 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) {
2398 BrowserWindowGtk* browser_window_gtk = new BrowserWindowGtk(browser); 2400 BrowserWindowGtk* browser_window_gtk = new BrowserWindowGtk(browser);
2399 browser_window_gtk->Init(); 2401 browser_window_gtk->Init();
2400 return browser_window_gtk; 2402 return browser_window_gtk;
2401 } 2403 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/one_click_signin_bubble_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698