Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 1425763002: X87: fix the sqrt issue. (Closed)

Created:
5 years, 1 month ago by chunyang.dai
Modified:
5 years, 1 month ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com, zhengxing.li
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: fix the sqrt issue. The test mjsunit/regress/regress-sqrt compares the result of Math.sqrt function when using full-compiler and turbofan/crankshaft compiler seperately. But according to glibc bug fixing(https://sourceware.org/bugzilla/show_bug.cgi?id=14032). The glibc implementation of std::sqrt() (It is invoked in the generated code when full-compiler is used.) will change since glibc 2.19. In order to keep consistence of Math.sqrt translation in turbofan compiler and the pass of mjsunit/regress/regress-sqrt. we translate the Math.sqrt func according to the same fix in glibc change. If the GLIBC version >=2.19, we will set the precision to Double. (the original is extended-double). This fix is to fix the same issue in https://codereview.chromium.org/606403002 for crankshaft. This fix may be ported for crankshaft too. BUG= Committed: https://crrev.com/d43bbd068dcdb7c4ad46d2a7cc6d303343ef58f8 Cr-Commit-Position: refs/heads/master@{#31592}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chunyang.dai
PTAL
5 years, 1 month ago (2015-10-27 05:55:45 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-10-27 07:55:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425763002/20001
5 years, 1 month ago (2015-10-27 07:55:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-10-27 08:14:12 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 08:14:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d43bbd068dcdb7c4ad46d2a7cc6d303343ef58f8
Cr-Commit-Position: refs/heads/master@{#31592}

Powered by Google App Engine
This is Rietveld 408576698