Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 606403002: X87: fix the Sqrt issue. (Closed)

Created:
6 years, 2 months ago by chunyang.dai
Modified:
6 years, 2 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: fix the Sqrt issue. The test mjsunit/regress/regress-sqrt compares the result of Math.sqrt function when using full-compiler and crankshaft compiler seperately. But according to glibc bug fixing(https://sourceware.org/bugzilla/show_bug.cgi?id=14032). The glibc implementation of std::sqrt() (It is invoked in the generated code when full-compiler is used.) will change since glibc 2.19. In order to keep consistence of Math.sqrt translation in crankshaft compiler and the pass of mjsunit/regress/regress-sqrt. we translate the Math.sqrt func by calling the runtime function. BUG=

Patch Set 1 #

Patch Set 2 : fix the comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -10 lines) Patch
M src/x87/lithium-codegen-x87.cc View 1 1 chunk +59 lines, -6 lines 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +8 lines, -2 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
chunyang.dai
WL. PTAL. thanks
6 years, 2 months ago (2014-09-29 02:54:57 UTC) #1
Weiliang
lgtm
6 years, 2 months ago (2014-09-29 08:37:44 UTC) #3
Weiliang
6 years, 2 months ago (2014-09-29 08:39:49 UTC) #4
Committed as r24271

Powered by Google App Engine
This is Rietveld 408576698